Add workflow ids in download-artifact actions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be seen with `gh workflow list` on the appropriate repo
tillrohrmann
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks for fixing this problem so quickly @jackkleeman. The changes look good to me. I had a few minor comments. +1 for merging after resolving them.
.github/workflows/e2e.yaml
Outdated
| @@ -107,6 +107,7 @@ jobs: | |||
| uses: dawidd6/action-download-artifact@v2 | |||
| with: | |||
| github_token: ${{ secrets.SDK_TYPESCRIPT_ACTION_READ_TOKEN || secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
Unrelated: Do we still need the github_token since the sdk-typescript repo is now public?
tillrohrmann
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can be seen with
gh workflow liston the appropriate repoFixes #248